Repository navigation
fix(tests): Fix two midnight UTC flakes - #127341
Merged
Merged
Conversation
- tagstore generic issue fixture stored its event at today 00:01 UTC, which is in the future for the first minute after midnight, so snuba.query's default end (now + 1s) excluded it. - test_handle_nans_from_snuba_top_n's last 1d bucket ends at today's midnight and comes back incomplete for 90s after it. Freeze time at noon.
kcons
approved these changes
Oct 13, 2026
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two test groups fail only in the first minutes after midnight UTC. Found while looking at #127333.
TagStorageTestgeneric issue tests (master runs 33696769930, 34292318033, 35288544029): the fixture stores its event at today 00:01 UTC. From 00:00:00 to 00:00:59 that's in the future, andsnuba.querydefaultsendto now + 1s, so the event is excluded. Store it atbefore_now(minutes=1)instead.test_handle_nans_from_snuba_top_n(master run 33696769930): the last 1d bucket ends at today's midnight, andincomplete_reasonflags it as incomplete until 90s after that, but the expected series hardcodesincomplete: False. Freeze time at today noon for the request.